Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt-data-type-definitions.json: Revisit ID Type and ID Source Type, refactor as Scheme ID, Scheme Agency ID, and use ID Type Code as a business defined name for the ID #156

Open
dubnemo opened this issue Dec 5, 2024 · 0 comments

Comments

@dubnemo
Copy link
Collaborator

dubnemo commented Dec 5, 2024

I still take the stance that the IDType defined is really a scheme, and IDSourceType is very confusing as both IDType and IDSourceType has GLN as an example.
A scheme defines the data representation, aka a formal descriptive way to parse and recognize the identifier, which in some case there will be logic in creating the identifer. UUID is a classic example, as GUID is the 'Microsoft way' or scheme and DCE created another scheme. There are many versions of each scheme as noted in RFC 9562. Therefore the IDSource in these examples are actually Microsoft or DCE. Just saying.

GTIN and GLN are other schemes, which the source is GS1.

I could go on an on. I bought this up the first day of the ADAPT kickoff meeting in Bloomington, citing ANSI ASC X12 as the origin of these concepts. UN/ECE spent considerable clock-cycles 'fixing this' with the notion of schemeId and schemeAgencyId, probably a LOT more human-hours spent debating this than we have spent in AgGateway.

ID Type in X12 was a business contextual name for the identifier, which is much different than a scheme since scheme is for the technical folks solving problems. The UN ended up calling this typeCode instead. I cannot remember if UN/EDIFACT also fixed the X12 submission to the UN/ECE but there were a lot of changes to address concerns like this.

Sorry I did not see this earlier.

@dubnemo dubnemo changed the title Revisit ID Type and ID Source Type, refactor as Scheme ID, Scheme Agency ID, and use ID Type Code as a business defined name for the ID adapt-data-type-definitions.json: Revisit ID Type and ID Source Type, refactor as Scheme ID, Scheme Agency ID, and use ID Type Code as a business defined name for the ID Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant