Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summer 2023 #17

Open
4 of 10 tasks
cortner opened this issue May 3, 2023 · 0 comments
Open
4 of 10 tasks

Summer 2023 #17

cortner opened this issue May 3, 2023 · 0 comments

Comments

@cortner
Copy link
Member

cortner commented May 3, 2023

Collecting jobs and todos here for the big code development push we are currently on, partly based on discussions on Zulip. Thank you @DexuanZhou for your summary.

  • Normalisation Ylm and Rlm: Verify the normalized constant for both solid harmonics and spherical harmonics, document this in the Polynomials4ML docs, check if there are other ways to normalize them, including the sense of norm used. -- @DexuanZhou
  • Unit tests for Rlm: verify they match the explicit expressions, check derivatives, follow test_cylm.jl -- @DexuanZhou
  • Unit tests for atomic orbitals: for Gaussian, Slater, and STO-NG functions. Check the derivatives of these functions and also verify the consistency of the standard and batched evaluation methods. -- @DexuanZhou
  • SparseProduct: implement a sparse product without pooling in Polynomials4ML from which we can build atomic orbital bases -- @cortner and @CheukHinHoJerry
  • AtomicOrbitalsBasis: implement the atomic orbitals basis which will be evaluating the atomic orbitals on multiple nuclei and merging them into a single basis. -- TBD
  • BackflowPooling: implement the custom backflow pooling as a separate operation from the AtomicOrbitalsBasis -- @cortner and @CheukHinHoJerry
  • Reorganize atorbbasis.jl : once the AtomicOrbitalsBasis and BackflowPooling is done, we can reorganize this into a very simple flux layer or chain -- TBD
  • Correlations: Here we should be able to just use the standard implementation. But we do need to implement some scripts that will give us different choices of which correlations to involve in the model. This is where the real modelling happens!! -- @DexuanZhou (??)
  • Clearly document the API

Additional comment that I don't fully understand yet - to be discussed in our next meeting?

@CheukHinHoJerry CheukHinHoJerry mentioned this issue Sep 29, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant