Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document cutoff for pair interaction #191

Open
YuanbinLiu opened this issue Apr 3, 2024 · 7 comments
Open

Document cutoff for pair interaction #191

YuanbinLiu opened this issue Apr 3, 2024 · 7 comments

Comments

@YuanbinLiu
Copy link

Hi authors,

Could you tell me how I can set different cutoff radii for 2-body and many-body interactions during training an ACE model? I couldn't find the specifics in the documentation.

@cortner
Copy link
Member

cortner commented Apr 3, 2024

Hi - thanks for the question. Do you mind moving it into a Discussion thread though rather than an issue?

@cortner cortner closed this as completed Apr 3, 2024
@cortner cortner reopened this Apr 3, 2024
@cortner
Copy link
Member

cortner commented Apr 3, 2024

I'm re-opening this, it needs an example in the documentation, so maybe it's an issue after all. Sorry about this.

@cortner cortner changed the title Cutoff for pair interaction Document cutoff for pair interaction Apr 3, 2024
@cortner
Copy link
Member

cortner commented Apr 3, 2024

Here is a complete list of (current) defaults and kwargs:

const _kw_defaults = Dict(:elements => nothing,
                          :order => nothing,
                          :totaldegree => nothing,
                          :wL => 1.5,
                          #
                          :rin => 0.0,
                          :r0 => :bondlen,
                          :rcut => (:bondlen, 2.5),
                          :transform => (:agnesi, 2, 4),
                          :envelope => (:x, 2, 2),
                          :rbasis => :legendre,
                          #
                          :pure2b => true,
                          :delete2b => true,
                          :pure => false,
                          #
                          :pair_rin => :rin,
                          :pair_rcut => :rcut,
                          :pair_degree => :totaldegree,
                          :pair_transform => (:agnesi, 1, 3),
                          :pair_basis => :legendre,
                          :pair_envelope => (:r, 2),
                          #
                          :Eref => missing
                          )

@cortner
Copy link
Member

cortner commented Apr 3, 2024

You can use this as follows:

model = acemodel(elements = [:Si,],
                 order = 3,
                 totaldegree = 10,
                 rcut = 5.0, 
                 pair_rcut = 8.0,
                 pair_degree = 20, 
        )

and so forth...

@cortner
Copy link
Member

cortner commented Apr 3, 2024

We should add a list of all defaults and options. Maybe this dictionary can be read in automatically during docs generation and a table generated from it.

@YuanbinLiu
Copy link
Author

YuanbinLiu commented Apr 3, 2024

@cortner, Thanks a lot for this! And it would be very helpful for users if there are some simple comments for each argument in the future documentation. For example, I am a bit confused about "pure2b", "delete2b", and "pure".

@cortner
Copy link
Member

cortner commented Sep 13, 2024

Coming back to this, the above applies to 0.6.x but not to 0.8.x. The last suggestion made here about combining lists of arguments with brief docs is good. Maybe we can then also use this to automatically generate documentation pages. Won't manage to do this for 0.8 release but a good idea for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants