Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training and Validation #80

Closed
cortner opened this issue Aug 30, 2024 · 3 comments
Closed

Training and Validation #80

cortner opened this issue Aug 30, 2024 · 3 comments

Comments

@cortner
Copy link
Member

cortner commented Aug 30, 2024

@tinatorabi is planning to implement a wrapper around the ASP solver that picks the best model from the model path based on a validation set. More generally I can envision us wanting to provide some limited hyperparameter selection based on a dataset split. This issue is to discuss a possible interface for this. In order to keep the package agnostic about the kind of data, I think there are two options:

solve(A, y, solver, Itrain, Ival)    # with Itrain, Ival vectors of row-indices
solve(Atrain, ytrain, Aval, yval, solver)

Maybe we can simply provide both and make the first option just a wrapper of the second option?

@wcwitt - do you have a view on this?

@cortner
Copy link
Member Author

cortner commented Sep 9, 2024

TODO: add validated TSVD interface

@cortner
Copy link
Member Author

cortner commented Sep 11, 2024

I think we have now settled on

solve( solver,  At, yt) 
solve( solver, At, yt, Av, yv )

and for not enforce the split to be done outside of ACEfit.

@cortner cortner closed this as completed Sep 11, 2024
@cortner
Copy link
Member Author

cortner commented Sep 11, 2024

was closed by #84 and #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant