preview diff/commit for changes #3380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| module github.com/99designs/gqlgen | |||
|
|
|||
| go 1.22.5 | |||
| go 1.23 | |||
There was a problem hiding this comment.
Hey, can you make sure you don't upgrade this by mistake?
alexandear
reviewed
Nov 24, 2024
| @@ -274,6 +275,21 @@ func Call(p *types.Func) string { | |||
| return pkg + p.Name() | |||
| } | |||
|
|
|||
| func dict(values ...interface{}) (map[string]interface{}, error) { | |||
| if len(values)%2 != 0 { | |||
| return nil, fmt.Errorf("invalid dict call: arguments must be key-value pairs") | |||
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("invalid dict call: arguments must be key-value pairs") | |
| return nil, errors.New("invalid dict call: arguments must be key-value pairs") |
| for i := 0; i < len(values); i += 2 { | ||
| key, ok := values[i].(string) | ||
| if !ok { | ||
| return nil, fmt.Errorf("dict keys must be strings") |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("dict keys must be strings") | |
| return nil, errors.New("dict keys must be strings") |
|
closing this PR as it was raised with partial changes. Will be raising a new PR in a while with complete changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview diff