Remove 1/Ts from raised-cosine calculation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was running this example and plotting the result of h returned an impulse response that peaked at 0.12.
|
Nice catch! It is strange that sources online, eg https://en.wikipedia.org/wiki/Raised-cosine_filter show the 1/Ts scaling but as a pulse shaping filter I don't see why you would want the scaling since you apply an FIR filter with convolve and you wouldn't want to scale the pulses... |
saltchicken
temporarily deployed
to
github-pages-pr
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running this example and plotting the result of h returned an impulse response that peaked at 0.12. This does not match with provided graph and it produces the wrong result for the convolution step.
Removing the scalar of 1/Ts for the sinc function seems to produce the correct result.
Disclaimer: This is not my field of expertise and study this for fun. I very well could be wrong.