Why the behaviors of <c-f>, <c-b>, <c-d> and <c-u> are select rather scroll?

[leira]

I'm a bit surprised when I first hit in Dance. I was expecting scrolling a page, but it selected instead. Then I found , and have the similar behavior, rather than scrolling. I double-checked the kakoune docs, they are mapped to scroll by default. What is the rational to change default behaviors from scroll in kakoune to select in Dance?

I changed the behavior to scroll using the setting below. I'm just curious on the reasons.

  {
    "key": "ctrl+f",
    "command": "dance.select.vertically",
    "args": {
      "direction": 1,
      "by": "page",
      "shift": "jump"
    },
    "when": "editorTextFocus && dance.mode == 'normal'"
  },

[71]

Looks like this was an error introduced by the switch to Dance 0.5 (2d38438). See #224 for tracking.

[leira]

Thanks for the reply, @71. I see. Pre-#224, c-f was bound to scroll a page. Thanks for the quick fix!

dance/commands/commands.yaml

Line 106 in 1b3e222

down.page:

down.page:
  title: Scroll one page down
  keys: c-f (normal), c-f (insert)

dance/src/commands/move.ts

Line 120 in 1b3e222

registerCommand(Command.downPage, CommandFlags.ChangeSelections, (_, { repetitions }) =>

registerCommand(Command.downPage, CommandFlags.ChangeSelections, (_, { repetitions }) =>
  scrollBy(repetitions, "down", "page"),
);