Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Feedback for improvement (unfiltered) #26

Open
EHJ-52n opened this issue Jun 12, 2014 · 0 comments
Open

Feedback for improvement (unfiltered) #26

EHJ-52n opened this issue Jun 12, 2014 · 0 comments

Comments

@EHJ-52n
Copy link
Member

EHJ-52n commented Jun 12, 2014

From user Fabien:
I wanted to give you some feedback by importance order for the tool :

  • could it be possible to add a step to request the sensor's type (thermometer...)
  • adding observations for several observed property (different sensor) doesn't work yet (but I think you know it as I saw it in code comment). It will only need to repeat some steps for each sensor/observed property like requesting sensor name, observed property and uom
  • for the unit of measure (step 6b), using '²' character causes an UTF8-error (added SOS log in attachment)
  • could the configuration file be applied to a fileset, for example I got 30 files for a mounth which only vary on the date. By setting a shortcut to the last step and only request a csv file and a config-file.xml or setting at first step a multiple target

Less important feedbacks :

  • append an other step for asking the user if he wants to add metadata which could be used in the client (like quality of the sensor, owner ...) with
<sml:characteristics>
    <swe:SimpleDataRecord definition="urn:x-ogc:def:property:stationProperties">
        <swe:field name="sensorquality">
            <swe:Text definition="urn:x-ogc:def:property:sensorquality">
                <swe:value>0.75</swe:value>
            </swe:Text>
        </swe:field>
        ...
    </swe:SimpleDataRecord>
</sml:characteristics>

for having a complete client as on http://sensorweb.demo.52north.org/sensorwebclient-webapp-stable/, when you click on a station provided by Pegelonline you got the river name for example which is set on the sensorML.

  • could the tool be a little more connected by requesting first url of the SOS, for parsing throught the GetCapabilities, which FOI, procedures and unit of measure already exist to avoid misspelling
  • could the policy when a file already been read be less strict, because it needs to rename the file if you want to use it again when you got an error while feeding (skip lines but data haven't been yet inserted in the database)"
2013-07-30 15:56:57,209 ERROR [http-apr-8080-exec-8] [SOS.java:234] Error while parsing request!
org.xml.sax.SAXParseException: Invalid byte 1 of 1-byte UTF-8 sequence.
    at org.apache.xerces.parsers.DOMParser.parse(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at javax.xml.parsers.DocumentBuilder.parse(Unknown Source) ~[na:1.7.0_17]
    at org.n52.sos.SOS.doPost(SOS.java:224) ~[52n-sos-core-3.5.0.jar:na]
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:647) [servlet-api.jar:na]
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:728) [servlet-api.jar:na]
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305) [catalina.jar:7.0.42]
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210) [catalina.jar:7.0.42]
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222) [catalina.jar:7.0.42]
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123) [catalina.jar:7.0.42]
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502) [catalina.jar:7.0.42]
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171) [catalina.jar:7.0.42]
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99) [catalina.jar:7.0.42]
    at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:953) [catalina.jar:7.0.42]
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) [catalina.jar:7.0.42]
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408) [catalina.jar:7.0.42]
    at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1023) [tomcat-coyote.jar:7.0.42]
    at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589) [tomcat-coyote.jar:7.0.42]
    at org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:1852) [tomcat-coyote.jar:7.0.42]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [na:1.7.0_17]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [na:1.7.0_17]
    at java.lang.Thread.run(Unknown Source) [na:1.7.0_17]
Caused by: org.apache.xerces.impl.io.MalformedByteSequenceException: Invalid byte 1 of 1-byte UTF-8 sequence.
    at org.apache.xerces.impl.io.UTF8Reader.invalidByte(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at org.apache.xerces.impl.io.UTF8Reader.read(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at org.apache.xerces.impl.XMLEntityScanner.load(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at org.apache.xerces.impl.XMLEntityScanner.scanLiteral(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at org.apache.xerces.impl.XMLScanner.scanAttributeValue(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanAttribute(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    at org.apache.xerces.parsers.XMLParser.parse(Unknown Source) ~[xercesImpl-2.9.1.jar:na]
    ... 22 common frames omitted
@EHJ-52n EHJ-52n added this to the 0.5.0 milestone Apr 27, 2015
EHJ-52n added a commit that referenced this issue Jan 29, 2017
* Update to latest 52N maven parent

- dependency managements updated:
  - remove outdated
  - add used and undeclared
  - add runtime scope if required
- fix javadoc
  - become compliant with HTML 4.0
  - add missing information

* Document version requirements for developers
* Minor updates
* Switch to Java 8
* Remove duplicate line from .travis.yml
* Minor layout change: \t -> '    '
* Checkstyle #1
* Checkstyle #2
* Checkstyle #3
* Checkstyle #4
* Checkstyle #4
* Checkstyle #5
* Checkstyle #6
* Checkstyle #7
* Checkstyle #8
* Checkstyle #9
* Checkstyle #10
* Checkstyle #11
* Checkstyle #12
* Checkstyle #13
* Checkstyle #14
* Checkstyle #15
* Checkstyle #16
* Checkstyle #17
* Checkstyle #18
* Checkstyle #19
* Checkstyle #20
* Checkstyle #21
* Checkstyle #22
* Checkstyle #23
* Checkstyle #24
* Checkstyle #25
* Checkstyle #26
* Checkstyle #27
* Checkstyle #28
* Checkstyle #29
* Remove not available jdk "openjdk8"
* Checkstyle #30
* Checkstyle #31
* Checkstyle #32
* Fix findbugs issues
* Fix findbugs issues #2
* Disable checkstyle for codeless module
* Add repos again and allow them
* Add 52n repositories
* Fix findbugs issues #3
* Findbugs #4
* Findbugs #5
* Findbugs #6
* Findbugs #7
* Findbugs #8
* Add missing dependencies
* Findbugs #9 && Checkstyle #33
* Findbugs #10
* Checkstyle #34
@EHJ-52n EHJ-52n modified the milestones: 0.5.0, 0.5.1 Jul 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant