Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scopes_supported is not required by OpenID spec #26

Open
radicand opened this issue Mar 3, 2023 · 3 comments
Open

scopes_supported is not required by OpenID spec #26

radicand opened this issue Mar 3, 2023 · 3 comments

Comments

@radicand
Copy link

radicand commented Mar 3, 2023

In https://github.com/4D-Technologies/openidconnect_flutter/blob/main/openidconnect/lib/src/config/openidconfiguration.dart#L71-L72 there is an unchecked assumption scopes_supported will be present in the discovery document. I use an IDP which does not have this, and per the RFC spec, while recommended, it is not required: https://www.rfc-editor.org/rfc/rfc8414#section-2 . Could there be a conditional check for this field similar to how other fields are conditionally checked?

@jhancock4d
Copy link
Contributor

Note that OAuth 2.0 is not OpenIdConnect. (it's as subset that is older than OpenIdConnect)

Do you have a reference to the OpenIdConnect relevant RFCs on this? Looks to me like it was changed to required along with claims_supported.

@radicand
Copy link
Author

Thanks for following up - it's the same RECOMMENDED in the OpenID Connect spec: https://openid.net/specs/openid-connect-discovery-1_0.html

@jhancock4d
Copy link
Contributor

See #20 . Trying to merge it all as one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants