Sohyupar java lv0 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generateRandomNumberByIdx -> ByMentionCount
오탈자 수정 및 누락된 논리부정 연산자 추가
Ssuamje
approved these changes
Jan 10, 2024
Comment on lines
+6
to
+7
| Jpark2 jpark2 = new Jpark2(); | ||
| Daewoole daewoole = new Daewoole(jpark2.getMentions()); |
There was a problem hiding this comment.
jpark2 객체에서 getMentions로 주입해주는 부분 좋은 것 같습니다! 다만 private final List mentions가 아닌 private final static으로 지정해서 클래스 자체에서 불러오도록 하면 더 좋았을 것 같아요!
enaenen
reviewed
Jan 10, 2024
|
|
||
| // 범위 내의 랜덤값 생성 | ||
| private int generateRandomNumberInRange(int min, int max) { | ||
| Random random = new Random(); |
There was a problem hiding this comment.
Random과 ThreadLocalRandom 에 대해서도 확인해보시면 좋을 것 같습니다
구조적으로는 더 말씀드릴게 없네요 너무 굳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.