Jihykim2 HTML + CSS, JS 제출 #12
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"/> | ||
| <title>Login Page</title> | ||
| <link href="style.css" rel="stylesheet"> | ||
| </head> | ||
| <body> | ||
| <div id="loginPage"> | ||
| <section class="leftLoginPage"> | ||
| <div class="serviceTitle"> | ||
| <p>42서울 캐비닛 서비스</p> | ||
| <p class="fontPurple">여러분의 일상을 가볍게</p> | ||
| </div> | ||
| <div class="serviceImage"> | ||
| <img src="images/undraw_work_in_progress_re_byic 1.svg"/> | ||
| </div> | ||
| <div class="serviceSubtitle"> | ||
| <p><span class="fontPurple">Cabi</span>로</p> | ||
| <p>일상의 무게를 덜어보세요.</p> | ||
| </div> | ||
| </section> | ||
| <section class="rightLoginPage"> | ||
| <div class="loginModal"> | ||
| <div class="logoImage"> | ||
| <img src="images/logo.svg"/> | ||
| </div> | ||
| <div class="logoTitle"> | ||
| <p>42Cabi</p> | ||
|
There was a problem hiding this comment. 아니,, 온보딩 피그마가 달랐어요,,,, 억울합니다,,, |
||
| <p class="subTitle fontPurple">여러분의 일상을 가볍게</p> | ||
| </div> | ||
| <button class="loginButton">L O G I N</button> | ||
|
There was a problem hiding this comment.
|
||
| </div> | ||
| </section> | ||
| </div> | ||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /* http://meyerweb.com/eric/tools/css/reset/ | ||
| v2.0 | 20110126 | ||
| License: none (public domain) | ||
| */ | ||
|
|
||
| html, body, div, span, applet, object, iframe, | ||
| h1, h2, h3, h4, h5, h6, p, blockquote, pre, | ||
| a, abbr, acronym, address, big, cite, code, | ||
| del, dfn, em, img, ins, kbd, q, s, samp, | ||
| small, strike, strong, sub, sup, tt, var, | ||
| b, u, i, center, | ||
| dl, dt, dd, ol, ul, li, | ||
| fieldset, form, label, legend, | ||
| table, caption, tbody, tfoot, thead, tr, th, td, | ||
| article, aside, canvas, details, embed, | ||
| figure, figcaption, footer, header, hgroup, | ||
| menu, nav, output, ruby, section, summary, | ||
| time, mark, audio, video { | ||
| margin: 0; | ||
| padding: 0; | ||
| border: 0; | ||
| font-size: 100%; | ||
| font: inherit; | ||
| vertical-align: baseline; | ||
| } | ||
| /* HTML5 display-role reset for older browsers */ | ||
| article, aside, details, figcaption, figure, | ||
| footer, header, hgroup, menu, nav, section { | ||
| display: block; | ||
| } | ||
| body { | ||
| line-height: 1; | ||
| } | ||
| ol, ul { | ||
| list-style: none; | ||
| } | ||
| blockquote, q { | ||
| quotes: none; | ||
| } | ||
| blockquote:before, blockquote:after, | ||
| q:before, q:after { | ||
| content: ''; | ||
| content: none; | ||
| } | ||
| table { | ||
| border-collapse: collapse; | ||
| border-spacing: 0; | ||
| } | ||
|
|
||
| /* Button reset */ | ||
| button { | ||
| background: none; | ||
| border: none; | ||
| padding: 0; | ||
| box-shadow: none; | ||
| border-radius: 0; | ||
| cursor: pointer; | ||
| font: inherit; | ||
| color: inherit; | ||
| outline: none; | ||
| -webkit-appearance: none; | ||
| -moz-appearance: none; | ||
| appearance: none; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| @import url("https://fonts.googleapis.com/css2?family=Noto+Sans+KR:[email protected]&display=swap"); | ||
| @import url("reset.css"); | ||
|
|
||
| /* all */ | ||
| html, body, #loginPage { | ||
| width: 100vw; | ||
| height: 100vh; | ||
| font-family: "Noto Sans KR"; | ||
|
There was a problem hiding this comment. font-family 에 family-name으로 지정된 글꼴 (Noto Sans KR)을 사용할 수 없을 경우를 대비해서 브라우저가 대체할 수 있는 폰트를 설정해주는 것이 좋습니다! font-family: 'Noto Sans KR', sans-serif; |
||
| } | ||
|
|
||
| #loginPage { | ||
| display: flex; | ||
| flex-direction: row; | ||
| } | ||
|
|
||
| /* colors */ | ||
| .fontPurple { | ||
| color: #B18CFF; | ||
|
There was a problem hiding this comment. 색깔은 CSS 변수를 사용해서 관리하는 것이 좋습니다! :root {
--white: #FFFFFF
--primary-color: #9747FF;
--secondary-color: #B18CFF;
--bg-color: var(--white);
}
.text-main {
color: var(--primary-color);
}
.text-sub {
color: var(--secondary-color);
} |
||
| } | ||
|
|
||
| /* margin, padding */ | ||
| div p { | ||
| padding: 10px 0; | ||
| } | ||
|
|
||
| /* contents */ | ||
| .leftLoginPage { | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
|
|
||
| width: 50%; | ||
| height: 100%; | ||
| padding-left: 7%; | ||
| box-sizing: border-box; | ||
|
|
||
| .serviceTitle { | ||
| font-size: 32px; | ||
| font-weight: 700; | ||
| } | ||
|
|
||
| .serviceImage { | ||
| width: 446px; | ||
| height: 388px; | ||
| padding: 10% 10%; | ||
|
There was a problem hiding this comment.
|
||
| } | ||
|
|
||
| .serviceSubtitle { | ||
| font-size: 28px; | ||
| font-weight: 700; | ||
|
|
||
| .fontPurple { | ||
| color: #9747FF; | ||
|
There was a problem hiding this comment.
|
||
| } | ||
| } | ||
| } | ||
|
|
||
| .rightLoginPage { | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
|
|
||
| width: 50%; | ||
| height: 100%; | ||
| background-color: #9747FF; | ||
|
|
||
| .loginModal { | ||
|
There was a problem hiding this comment. BEM 네이밍 컨벤션을 적용하면 재사용성과 가독성을 더 높힐 수 있어 보입니다! 이름을 유지하면서 BEM (Block Element Modifier) 컨벤션을 적용하면 아래처럼 될 것 같아요: .login-modal {
display: flex;
flex-direction: column;
align-items: center;
justify-content: space-between;
width: 360px;
height: 500px;
background-color: #FFFFFF;
border-radius: 20px;
box-sizing: border-box;
padding: 85px 0;
box-shadow: 10px 10px 40px 0px #00000040;
}
.login-modal__logo-image {
width: 70px;
height: 70px;
}
.login-modal__logo-title {
display: flex;
flex-direction: column;
align-items: center;
font-size: 40px;
}
.login-modal__sub-title {
font-size: 16px;
}
.login-modal__login-button {
width: 200px;
height: 60px;
border-radius: 6px;
background-color: #9747FF;
color:#FFFFFF;
font-size: 18px;
}There was a problem hiding this comment. 추가적으로, 이름에 login 이 두번 붙으면 클래스명이 너무 길어질 수 있으니 |
||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| width: 360px; | ||
| height: 500px; | ||
| background-color: #FFFFFF; | ||
|
There was a problem hiding this comment.
|
||
| border-radius: 20px; | ||
|
There was a problem hiding this comment.
|
||
| box-sizing: border-box; | ||
| padding: 85px 0; | ||
| box-shadow: 10px 10px 40px 0px #00000040; | ||
|
There was a problem hiding this comment.
|
||
|
|
||
| .logoImage { | ||
| width: 70px; | ||
| height: 70px; | ||
| } | ||
|
|
||
| .logoTitle { | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| font-size: 40px; | ||
|
|
||
| .subTitle { | ||
| font-size: 16px; | ||
| } | ||
| } | ||
|
|
||
| .loginButton { | ||
| width: 200px; | ||
| height: 60px; | ||
| border-radius: 6px; | ||
| background-color: #9747FF; | ||
| color:#FFFFFF; | ||
| font-size: 18px; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /* bonus */ | ||
| @media (max-width: 768px) { | ||
| .leftLoginPage { | ||
| display: none; | ||
| } | ||
|
|
||
| .rightLoginPage { | ||
| width: 100%; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로고가
70px*70px여야 요청사항에 부합합니다!