Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stellar support #61

Closed
wants to merge 14 commits into from
Closed

Add Stellar support #61

wants to merge 14 commits into from

Conversation

jzethar
Copy link
Collaborator

@jzethar jzethar commented Dec 4, 2023

This PR contains modules for Stellar blockchain: main module and operations module

@Har01d
Copy link
Collaborator

Har01d commented Feb 26, 2024

There are some issues:

  • We don't seem to be taking source address into account. For example, for transaction 166798028ca757a82f6ae3e9b83eb16309a961a72fe682db7643cbe68c8f39f7 nothing is being returned for GA4SDHEDDRLOLR73QKBIWRP3SO4C7XZD6QIYQE67OYG7ALFXPEM5RRQA (note that the fee payer and the source are two different addresses for this transaction). So we need to make two extra events for the source address and a special address (the-void or operations?)
  • Fees are going into the-void, but there are no reward transactions. We should either add them, or use the validator address instead of the-void (like we do in EVM modules)
  • The two modules should be merged (?)

@Har01d Har01d changed the title Stellar module Add Stellar support Feb 27, 2024
Copy link
Collaborator

@Har01d Har01d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvements are required.


foreach ($currencies_to_process as $k => $v)
if (is_null($v))
$currencies_to_process[$k] = 'xlm';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xlm shouldn't be hard-corded in top-level modules.

Modules/Common/StellarLikeOperationsModule.php Outdated Show resolved Hide resolved

/* This module processes main transactions in Stellar. Requires a Stellar node. */

abstract class StellarLikeMainModule extends CoreModule
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing extra_data_model and extra_data_details.

@Har01d
Copy link
Collaborator

Har01d commented Jun 21, 2024

These two modules should be merged into a single one as the main module doesn't process anything besides fees.

@Har01d
Copy link
Collaborator

Har01d commented Jul 24, 2024

Closing in favour of #99.

@Har01d Har01d closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants