-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stellar support #61
Conversation
There are some issues:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improvements are required.
|
||
foreach ($currencies_to_process as $k => $v) | ||
if (is_null($v)) | ||
$currencies_to_process[$k] = 'xlm'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xlm
shouldn't be hard-corded in top-level modules.
|
||
/* This module processes main transactions in Stellar. Requires a Stellar node. */ | ||
|
||
abstract class StellarLikeMainModule extends CoreModule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing extra_data_model
and extra_data_details
.
These two modules should be merged into a single one as the |
Closing in favour of #99. |
This PR contains modules for Stellar blockchain: main module and operations module