Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THREESCALE-11500: Fix confusing design flaw in "promote" UI (Part 1) #3953

Merged

Conversation

lvillen
Copy link
Contributor

@lvillen lvillen commented Dec 13, 2024

THREESCALE-11500: Fix confusing design flaw in "promote" UI

This issue exposes two problems, this PR deals with the first part:
"The Promote button is not enabled immediately when changes are done. Instead a job is enqueued and the button is enabled when this job is executed."

With the help of @jlledom, we've reached to the conclusion that not knowing when a job is going to be executed is a problem here. In this PR, we're removing the job who deals with updating proxy_configs_affecting_changes table and, instead, we propose to update the table directly at the ProxyConfigEventSubscriber. We don't think this will imply any substantial downgrade in the performance but we're open to discussion.

Verification steps

  1. Go to Products > Integrations
  2. Make a change there, could be adding a Mapping Rule or modifying the Policies, for example
  3. Go to Integrations > Configuration and confirm the Promote button is enabled

@lvillen lvillen force-pushed the THREESCALE-11500_fix-confusing-design-flaw-in-promote-ui branch from e77d810 to f2c1939 Compare December 18, 2024 16:26
@lvillen lvillen force-pushed the THREESCALE-11500_fix-confusing-design-flaw-in-promote-ui branch from f2c1939 to 19dc2f4 Compare December 19, 2024 15:27
@lvillen lvillen requested review from jlledom and mayorova December 20, 2024 08:26
@lvillen lvillen merged commit a3461ff into master Jan 9, 2025
17 of 21 checks passed
@lvillen lvillen deleted the THREESCALE-11500_fix-confusing-design-flaw-in-promote-ui branch January 9, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants