THREESCALE-11500: Fix confusing design flaw in "promote" UI (Part 1) #3953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THREESCALE-11500: Fix confusing design flaw in "promote" UI
This issue exposes two problems, this PR deals with the first part:
"The Promote button is not enabled immediately when changes are done. Instead a job is enqueued and the button is enabled when this job is executed."
With the help of @jlledom, we've reached to the conclusion that not knowing when a job is going to be executed is a problem here. In this PR, we're removing the job who deals with updating
proxy_configs_affecting_changes
table and, instead, we propose to update the table directly at theProxyConfigEventSubscriber
. We don't think this will imply any substantial downgrade in the performance but we're open to discussion.Verification steps