Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YahooImpl doesn't work #106

Open
bogdan-nourescu opened this issue Mar 7, 2017 · 1 comment
Open

YahooImpl doesn't work #106

bogdan-nourescu opened this issue Mar 7, 2017 · 1 comment

Comments

@bogdan-nourescu
Copy link
Contributor

Hello,
I am writing to let you know that the YahooImpl doesn't work anymore with OAuth1.
I have changed the code to work with OAuth2, but you need to consider this changes:

ENDPOINTS.put(Constants.OAUTH_AUTHORIZATION_URL,
                "https://api.login.yahoo.com/oauth2/request_auth");
ENDPOINTS.put(Constants.OAUTH_ACCESS_TOKEN_URL,
                "https://api.login.yahoo.com/oauth2/get_token");

Use OAuth2. In OAuth2 you also need to change the method from GET to POST for OAUTH_ACCESS_TOKEN_URL (line 114)

I will make a pull request for it, but i am just posting in case there is someone searching for why Yahoo is not working anymore.

@bogdan-nourescu
Copy link
Contributor Author

Added the pull request for the upgrade from OAuth 1 to OAuth2
#107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant