Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve unsafe implementation of TrustManager, X509TrustManager #103

Open
westonal opened this issue Feb 3, 2017 · 1 comment
Open

Resolve unsafe implementation of TrustManager, X509TrustManager #103

westonal opened this issue Feb 3, 2017 · 1 comment

Comments

@westonal
Copy link

westonal commented Feb 3, 2017 •
edited
Loading

Since May 17, 2016 Google has begun blocking new apps, and app updates containing "unsafe" implementations of X509TrustManager

Details here: https://support.google.com/faqs/answer/6346016
@westonal westonal changed the title Remove unsafe implementation of TrustManager Remove unsafe implementation of TrustManager, X509TrustManager Feb 3, 2017
@westonal westonal changed the title Remove unsafe implementation of TrustManager, X509TrustManager Resolve unsafe implementation of TrustManager, X509TrustManager Feb 3, 2017
@dpreussler
Copy link

This needs to be fixed or android applications can not use socialauth anymore.

What is the need of the Trustmanager code in org.brickred.socialauth.util.HttpUtil?
The doc does not say it.
The froyo code can be thrown out anyway as its less than 1% of Android users
https://developer.android.com/about/dashboards/index.html
But there is still a class DefaultTrustManager that does not perform any certificate checks for all other versions there.

dpreussler pushed a commit to dpreussler/socialauth that referenced this issue Feb 5, 2017
3pillarlabs#103: removed trust manager code
1256975
sayantam added a commit that referenced this issue May 8, 2017
@sayantam
Merge pull request #104 from dpreussler/dev
84d2c24 
#103: removed unsecure trust manager code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpreussler @westonal