Replace use of return keyword as logic control inside AR transactions, as this is not supported in Ruby 3 #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the below deprecation warning as we prepare CRMP and associated plugins (i.e. this, draft_approve) for Ruby 3 upgrade.
I'll be the first to say this is not a pretty fix.
It tweaks some of the logic used inside Active Record transaction blocks to remove the old syntax and replaces it with variable assignments than then return stuff outside of the block. Thrilling stuff 😆