Add notification for old browsers #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Тут я подумал, что название |
osvodef
suggested changes
Jun 6, 2018
| @@ -0,0 +1,83 @@ | |||
| var ie9 = (function() { | |||
There was a problem hiding this comment.
Не стоит ли эту проверку в DG.Browser и вынести?
There was a problem hiding this comment.
Думаю, что нет, так мы не будем расширять публичные методы и в будущем сможем без колебаний ее выпилить
|
Лично я не против названия |
egoroof
reviewed
Jun 7, 2018
src/doc/en/manual/map.md
Outdated
| <td><code><b>museum</b></code></td> | ||
| <td><code>Boolean</code></td> | ||
| <td><code>true</code></td> | ||
| <td>Whether the message about unsupported browser be displayed.</td> |
egoroof
approved these changes
Jun 8, 2018
osvodef
approved these changes
Jun 8, 2018
|
Поднял значение |
osvodef
approved these changes
Jun 14, 2018
src/DGMuseum/src/DGMuseum.js
Outdated
| @@ -70,6 +79,14 @@ DG.Map.Museum = DG.Handler.extend({ | |||
|
|
|||
| _onCloseButtonClick: function(e) { | |||
| DG.DomEvent.stop(e); | |||
|
|
|||
| // Old Safari throws error when localStorage.getItem calls in private mode | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В рамках #474 добавил показ сообщения о том, что браузер пользователя не поддерживается.
Чтобы сообщение не показывалось, нужно передать в карту опцию при инициализации
museum: false.