-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The getter 'iterator' was called on null #40
Comments
I created a PR with a suggested solution. |
Hey @ricsmania thanks so much for the PR, this is another great catch! We reviewed it, and it happens quite often, in complex rigs, that people use empty nodes as targets. It would be beneficial to save the extra memory and check for the
Feel free to update your PR with this, and we'll merge it! |
Thanks for your continued contributions @ricsmania! |
@umberto-sonnino I updated the PR with your suggestion. I also saw another unchecked part here on actor_node.dart: bool all(NodeWalkCallback cb) {
if (cb(this) == false) {
return false;
}
// here
for (ActorNode child in _children) {
if (cb(child) == false) {
return false;
}
child.eachChildRecursive(cb);
}
return true;
} I didn't get any errors there, so I left it alone, but if you think that should also be checked I can add it too. @luigi-rosso no problem, I'm happy to help! |
Hey, I came across this error while I was making an app, is there any solution that i can implement?, Like I tried to delete all the empty nodes from my flare file. But it did not do anything |
@ricsmania , thanks a lot your solution worked I would also like to point out that in the
which is now working completely fine. I will make a PR for it soon. |
When creating a FlareActor with one specific animation I get this error: The getter 'iterator' was called on null.
This is the Flare file that causes the problem: https://www.2dimensions.com/a/uxteam/files/flare/progress_circle_v2
And this is the code, it's very simple:
This is the full error stack:
The text was updated successfully, but these errors were encountered: