Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve LED Buffer after Rotation #14

Open
203Null opened this issue Jun 10, 2022 · 2 comments
Open

Preserve LED Buffer after Rotation #14

203Null opened this issue Jun 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@203Null
Copy link
Member

203Null commented Jun 10, 2022

Currently, after an LED is set, it is directly written into the Device layer managed LED buffer. That means the positional info of it is lost.

When we need to rotate the buffer, we don't know the color in the buffer's XY position to conduct the rotation.
A possible solution is that the device layer will provide the system layer with an API to reverse calculate XY based on buffer index.

The implementation right now is that all buffers will be wiped after rotation. 5e7dfb7

@203Null 203Null added the enhancement New feature or request label Jun 10, 2022
@203Null
Copy link
Member Author

203Null commented Jun 25, 2022

I believe it's ideal for the device layer to provide an Index to XY look-up function. Otherwise, the system/application layer can not get current buffer data.

@203Null
Copy link
Member Author

203Null commented Jan 26, 2023

Currently, the OS will clear all layers upon rotation. This might not be idea in edge cases but good enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant