Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service section added #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mkgupta01
Copy link

@mkgupta01 mkgupta01 commented Jan 16, 2022

Thank you for your contribution to Dust-Road-Co 🤩🤩

GitHub license Open Source Love PRs Welcome

Please mention the following in order to get PR merged 🙌🏻🙌🏻

  1. Kind of change this PR introduce : service section added
  2. Issue it resolves : Service section added
  3. GitHub Page Link : https://mayankkuamr001.github.io/Dust-Road-Co/#services

@2024-SANDHYA
Copy link
Owner

Add what's asked in the PR properly, mention the issue don't just write. @mayankkuamr001

@mkgupta01
Copy link
Author

Updated @2024-SANDHYA

Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, you were not supposed to copy-paste every content. At least see what the website is about and what are you mentioning there. Like cloud service and all those. The image was for the idea.
Also, I don't want this outside box and spacing b/w the cards are also very less @mayankkuamr001 Another thing issue was never assigned to you without that you cannot create a PR it won't be merged. Do you want me to assign the issue to you now ?

image

@mkgupta01
Copy link
Author

Sorry for inconvenience ... Actually this was my first contribution on github. I am a beginner in open source so I am still on my learning phase.Secondly I just created the template for the service section and I thought the data will be filled by someone else.
Beside that I can remove the outer box and increase the space between the box so please assign the issue to me.

@2024-SANDHYA
Copy link
Owner

Comment on the issue first @mayankkuamr001

@mkgupta01 mkgupta01 closed this Jan 17, 2022
@2024-SANDHYA 2024-SANDHYA reopened this Jan 17, 2022
@2024-SANDHYA
Copy link
Owner

Why are you closing the PR, issue is assigned to you @mayankkuamr001

@mkgupta01
Copy link
Author

I made the changes.Kindly check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create our services section
2 participants