Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added hiring page #49

Closed
wants to merge 1 commit into from
Closed

added hiring page #49

wants to merge 1 commit into from

Conversation

AmanRana10
Copy link

@AmanRana10 AmanRana10 commented Jan 2, 2022 •
edited
Loading

Thank you for your contribution to Dust-Road-Co 🤩🤩

GitHub license Open Source Love PRs Welcome

Please mention the following in order to get PR merged 🙌🏻🙌🏻

  1. Kind of change this PR introduce : Added hiring page
  2. Issue it resolves : Hiring-Page  #43
  3. GitHub Page Link : https://amanrana10.github.io/Dust-Road-Co/
    Hiring page - Google Chrome 02-01-2022 13_19_34
    Hiring page - Google Chrome 02-01-2022 13_19_48

@AmanRana10 AmanRana10 mentioned this pull request Jan 2, 2022
Open
@2024-SANDHYA
Copy link
Owner

Provide GitHub page link, not the screenshots please @AmanRana10

@AmanRana10
Copy link
Author

Done @2024-SANDHYA

2024-SANDHYA
2024-SANDHYA requested changes Jan 3, 2022
View reviewed changes
Copy link
Owner

@2024-SANDHYA 2024-SANDHYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design should be such that it should go with the website, in the website you created everything is clustered, no footer, no header completely different. I am not liking the design either. Please look for some design inspiration on Dribble or Behance.

@AmanRana10
Copy link
Author

AmanRana10 commented Jan 3, 2022 •
edited
Loading

Ok will work on header...but I think the footer should be the same as that of the home page..also by clustered what do you mean exactly is it not responsive ??

@2024-SANDHYA
Copy link
Owner

Ok will work on header...but I think the footer should be the same as that of the home page..also by clustered what do you mean exactly is it not responsive ??

no no, clustered as in it's a bit messy and not organized @AmanRana10

@2024-SANDHYA
Copy link
Owner

Been 8 days, you have 2 more days to create the PR @AmanRana10

@AmanRana10
Copy link
Author

My end term is going on so i wouldn't be able to finish it...sorry @2024-SANDHYA

@2024-SANDHYA
Copy link
Owner

My end term is going on so i wouldn't be able to finish it...sorry @2024-SANDHYA

You are supposed to mention it then, it's your responsibility. @AmanRana10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2024-SANDHYA 2024-SANDHYA 2024-SANDHYA requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hiring-Page
2 participants
@AmanRana10 @2024-SANDHYA