Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release assets should be signed #26

Open
jlebon opened this issue Sep 6, 2023 · 5 comments
Open

Release assets should be signed #26

jlebon opened this issue Sep 6, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@jlebon
Copy link

jlebon commented Sep 6, 2023

Can you provide a detached signature of the binaries when doing releases?

@1player
Copy link
Owner

1player commented Sep 8, 2023

Sure, though I don't know how to get started with that. Do you have any pointers?

@1player
Copy link
Owner

1player commented Sep 9, 2023

I've looked into this, and I'm not exactly sure what kind of benefit would it provide over just compiling the application yourself if you do not trust the binaries.

Also, were I to set it up, I would use more sane tools like OpenBSD's signify or minisign, than the abomination that is PGP/GPG. Given that I don't know why you need signatures, I'm not even sure if you require any specific format or it would just be a lot of work that is ultimately not very useful.

Again, I'm just ambivalent about the idea, so I'd like to know more about your use case to form a plan of action.

@1player 1player added the enhancement New feature or request label Sep 9, 2023
@jlebon
Copy link
Author

jlebon commented Sep 11, 2023

I'm not familiar with signify or minisign but am willing to learn to use it if it's available in Fedora. That said, if there isn't demand for it, I'm OK just recompiling it myself for now and saving yourself the overhead. :) (But ideally, it'd be nice if either this gets packaged into Fedora or folded into toolbx.)

@1player
Copy link
Owner

1player commented Sep 12, 2023

The overhead with minisign is pretty minimal, I'm just not sure what these signatures are supposed to defend against... ultimately I offer binaries to download, so you will still have to trust me, or Github Actions in this case, that they've not been tampered with.

BTW, there is an pending request from your colleague in #10 to adapt the code to be used in toolbx, but the discussion has stalled for the moment.

@jlebon
Copy link
Author

jlebon commented Sep 12, 2023

As is, one has to trust both you and GitHub (or that it hasn't been compromised). If the binaries are signed, one only has to trust you (which I already do, since I use your code :) ). But again, I'm OK recompiling from tags (though ideally, those would be signed too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants