Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Unable to skip overwriting local snapshot using one line command #86

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix: Unable to skip overwriting local snapshot using one line command #86

wants to merge 1 commit into from

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

This PR applies the approach of --include_files to the --overwrite_local_copy flag to make it skippable without prompt.

Verification Process

  1. cd to a WordPress directory.
  2. Pull a snapshot using wp pull <snapshot_id>.
  3. See the prompt whether to overwrite the local snapshot.
  4. Ctrl-C to abort the command.
  5. Pull a snapshot using wp pull <snapshot_id> --overwrite_local_copy=false.
  6. See the pull runs without overwrite local copy prompt.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #85.

Changelog Entry

Fixed: Allow skipping --overwrite_local_copy without prompt.

@dinhtungdu dinhtungdu mentioned this pull request May 23, 2021
Open
@jeffpaul jeffpaul added this to the 2.2.0 milestone May 24, 2021
@jeffpaul jeffpaul modified the milestones: 2.2.0, 2.2.1 May 26, 2021
@jeffpaul jeffpaul mentioned this pull request May 26, 2021
Open
13 tasks
@jeffpaul
Copy link
Member

@eugene-manuilov @tlovett1 let me know if there's intent to take action on this PR or if we should close it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugene-manuilov eugene-manuilov Awaiting requested review from eugene-manuilov

@tlovett1 tlovett1 Awaiting requested review from tlovett1

At least 1 approving review is required to merge this pull request.

Assignees

@dinhtungdu dinhtungdu

Labels
None yet
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

Unable to skip overwriting local snapshot using one line command
2 participants
@dinhtungdu @jeffpaul