Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModuleGraph constructors #1416

Closed
plafer opened this issue Jul 26, 2024 · 1 comment
Closed

Fix ModuleGraph constructors #1416

plafer opened this issue Jul 26, 2024 · 1 comment
Labels
assembly Related to Miden assembly good first issue Good for newcomers

Comments

@plafer
Copy link
Contributor

plafer commented Jul 26, 2024

This should be done once #1226 is closed (specifically after all 4 points in #1226 (comment) are addressed)

Originally posted by @bobbinth in #1401 (comment)

For example, we could have the following constructors:

pub fn new(kernel: Kernel, libraries: IntoIterator<Item = CompiledLibrary>) -> Self {
    todo!("implement")
}

pub fn with_kernel(kernel: Kernel) -> Self {
    todo!("implement")
}

pub fn with_libraries(libraries: IntoIterator<Item = CompiledLibrary>) -> Self {
    todo!("implement")
}

And Assembler::default() could still be used to instantiate an empty assembler (i.e., the assembler without kernel or libraries).

@plafer plafer added good first issue Good for newcomers assembly Related to Miden assembly labels Jul 26, 2024
@plafer plafer changed the title For example, we could have the following constructors: Fix ModuleGraph constructors Jul 26, 2024
@bobbinth
Copy link
Contributor

bobbinth commented Aug 7, 2024

Ah - I forgot about this issue and created #1433. I'll close this one as the new one has a more up-to-date description of the proposed constructors.

@bobbinth bobbinth closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assembly Related to Miden assembly good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants