fix: cdk603 error calculating previousLocalExitRoot #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanestebanr
force-pushed
the
fix/cdk603-previousLER_error-v2
branch
from
96c7e2d
to
1d4224c
Compare
joanestebanr
changed the title
|
ToniRamirezM
approved these changes
Nov 27, 2024
vcastellm
reviewed
Nov 27, 2024
| @@ -6,6 +6,7 @@ CREATE TABLE certificate_info ( | |||
| height INTEGER NOT NULL, | |||
| certificate_id VARCHAR NOT NULL PRIMARY KEY, | |||
| status INTEGER NOT NULL, | |||
| previous_local_exit_root VARCHAR , | |||
There was a problem hiding this comment.
Suggested change
| previous_local_exit_root VARCHAR , | |
| previous_local_exit_root VARCHAR, |
vcastellm
reviewed
Nov 27, 2024
vcastellm
reviewed
Nov 27, 2024
|
|
||
| return fmt.Sprintf("Height: %d, CertificateID: %s, NewLocalExitRoot: %s. Status: %s. Errors: [%s]", | ||
| c.Height, c.CertificateID.String(), c.NewLocalExitRoot.String(), c.Status.String(), errors) | ||
| previousLocalExitRoot := "nil" |
There was a problem hiding this comment.
use the nilStr constant?
vcastellm
reviewed
Nov 27, 2024
| @@ -23,6 +23,8 @@ const ( | |||
| Candidate | |||
| InError | |||
| Settled | |||
|
|
|||
| nilStr = "nil" | |||
There was a problem hiding this comment.
Why is this needed, agglayer API?
vcastellm
reviewed
Nov 27, 2024
| @@ -283,7 +285,7 @@ func TestAggSenderStart(t *testing.T) { | |||
| ctx, | |||
| log.WithFields("test", "unittest"), | |||
| Config{ | |||
| StoragePath: "file::memory:?cache=shared", | |||
| StoragePath: "file:TestAggSenderStart?mode=memory&cache=shared", | |||
There was a problem hiding this comment.
Are we 100% sure this is using memory or a file with this name?
vcastellm
reviewed
Nov 27, 2024
Stefan-Ethernal
pushed a commit
that referenced
this pull request
Nov 27, 2024
Support `agglayer:0.2.0-rc.15` the responses of ` CertificateHeader` add a new field: `PreviousLocalExitRoot` - Fixes error calculating previousLocalExitRoot on new certificate if a certificate is inError NOTE: **Database incompatibility with previous version!, require to delete it!**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
agglayer:0.2.0-rc.15the responses ofCertificateHeaderadd a new field:PreviousLocalExitRootNOTE: Database incompatibility with previous version!, require to delete it!