Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async is a keyword from python 3.7 causing incompatibility in tests. #232

Open
tirkarthi opened this issue Apr 21, 2020 · 2 comments
Open

Comments

@tirkarthi
Copy link

async is a keyword from Python 3.7 so tests will fail with SyntaxError in Python 3.7 and above

rg 'async='
tests/test_client_async.py
56:    async_result = client.add(1, 4, async=True)
87:    async_result = client.lolita(async=True)
90:    async_result = client.add(1, 4, async=True)
@bombela
Copy link
Member

bombela commented Apr 21, 2020

Ok so we might still be able to keep async on the function side, for backward compatibility, and add a new alias keyword. Just need to find a good name...

async_result = client.add(1, 4, async_result=True) maybe...

@VeNoMouS
Copy link

VeNoMouS commented Jun 7, 2020

workaround

while... really not ideal, a workaround for the existing code..

client.add(**{'async': True, 'a': 1, 'b': 4})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants