Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing raft client activity even if there's no defined ctl-svc entry? #38

Open
00pauln00 opened this issue Nov 24, 2020 · 1 comment
Assignees

Comments

@00pauln00
Copy link
Owner

I'm wondering if we should create a ctl-svc entry for a client whose info had not been declared at server startup time? This would reinstate some of the functionality which had existed prior to tcp support while still (hopefully) allowing for tcp operation to function properly.

If not we need to address the comment in raft_server_client_recv_ignore_request() which incorrectly states:

 /* Lookup the client in the ctl-svc-node tree - existence is not                                     
   * mandatory.                                                                                        
   */
@kitwestneat
Copy link
Collaborator

That looks doable. I think we'd have to start sending the port #s in the handshake since the TCP from port is a random number.

Do you think it'd be alright to replace from with csn in the calls to ri_server_recv_cb and ri_client_recv_cb? That would move a lot of message validation to raft_net, which I think makes sense.

(Sorry for not responding earlier, I'm still getting used to github's workflow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants